Submitted by Timenov, hunterw3b, Kodak, SBSecurity, Fides, mylifechangefast, SanketKogekar. Selected submission by: SBSecurity.

Relevant GitHub Links

Summary

There are functions that don’t emit events.

Vulnerability Details

Functions:
GMXDeposit::processDepositFailure
GMXCompound::compound
GMXEmergency::emergencyResume
GMXManager::borrow
GMXManager::repay
GMXRebalance::rebalanceAdd
GMXRebalance::rebalanceRemove
GMXVault::mintFee
GMXWithdraw::processWithdrawFailure
GMXWorker::addLiquidity
GMXWorker::removeLiquidity
GMXWorker::swapExactTokensForTokens
GMXWorker::swapTokensForExactTokens

Impact

External users, frontend, or blockchain monitoring won’t announce for these critical functions.

Tools Used

Manual

Recommendations

Add events where possible for critical operations.